Re: [PATCH v3 07/14] iommufd/viommu: Add iommufd_viommu_get_vdev_id helper

[Baolu Lu]

On 1/3/25 04:29, Jason Gunthorpe wrote:
> On Mon, Dec 23, 2024 at 10:28:32AM +0800, Baolu Lu wrote:
>
> > However, considering page fault scenarios, which are self-contained but
> > linked to a hardware page table (hwpt), introduces ambiguity. Hwpt can
> > be created with or without a vIOMMU. This raises the question: should
> > the page fault message always report the iommufd device ID, or should
> > the reporting depend on whether the hwpt was created from a vIOMMU?
> I think every single event record read from the FD needs to clearly
> specify what its fields are.

That would work.

> Page fault need to clearly say it's field is a device ID.

Each field of fault message has been specified in uapi/linux/iommufd.h.

---
baolu