Re: [PATCH 2/3] remoteproc: k3-dsp: Fix checks in k3_dsp_rproc_{mbox_callback/kick}

[Siddharth Vadapalli]

On Tue, Dec 24, 2024 at 02:44:56PM +0530, Beleswar Padhi wrote:
> Commit ea1d6fb5b571 ("remoteproc: k3-dsp: Acquire mailbox handle during
> probe routine") introduced a check in the "k3_dsp_rproc_mbox_callback()"
> and "k3_dsp_rproc_kick()" callbacks to exit if the remote core's state
> was "RPROC_DETACHED". However, this caused issues in IPC-only mode, as
> the default state of the core is set to "RPROC_DETACHED", and the
> transition to "RPROC_ATTACHED" happens only after the "__rproc_attach()"
> function has invoked "rproc_start_subdevices()".
> 
> The "rproc_start_subdevices()" function triggers the probe of Virtio
> RPMsg subdevices, which require the mailbox callbacks to be functional.
> To resolve this, a new variable, "is_attach_ongoing", is introduced to
> distinguish between core states: when a core is actually detached and
> when it is in the process of being attached. The callbacks are updated
> to return early only if the core is actually detached and not during an
> ongoing attach operation in IPC-only mode.
> 
> Reported-by: Siddharth Vadapalli <s-vadapalli@xxxxxx>
> Closes: https://lore.kernel.org/all/20240916083131.2801755-1-s-vadapalli@xxxxxx/
> Fixes: ea1d6fb5b571 ("remoteproc: k3-dsp: Acquire mailbox handle during probe routine")
> Signed-off-by: Beleswar Padhi <b-padhi@xxxxxx>

Reviewed-by: Siddharth Vadapalli <s-vadapalli@xxxxxx>

Regards,
Siddharth.