Re: [PATCH 4/4] arm64: dts: qcom: ipq5424: Enable PCIe PHYs and controllers

From: Varadarajan Narayanan
Date: Fri Jan 03 2025 - 01:53:17 EST


On Fri, Dec 13, 2024 at 07:19:50PM +0530, Manikanta Mylavarapu wrote:

[ . . . ]

> +&pcie2_phy {
> + status = "okay";
> +};
> +
> +&pcie2 {
> + pinctrl-0 = <&pcie2_default_state>;
> + pinctrl-names = "default";
> +
> + perst-gpios = <&tlmm 31 GPIO_ACTIVE_LOW>;
> + status = "okay";
> +};

pcie2 should come before pcie2_phy

> +
> +&pcie3_phy {
> + status = "okay";
> +};
> +
> +&pcie3 {
> + pinctrl-0 = <&pcie3_default_state>;
> + pinctrl-names = "default";
> +
> + perst-gpios = <&tlmm 34 GPIO_ACTIVE_LOW>;
> + status = "okay";
> +};

same here.

-Varada