RE: [PATCH v2] Revert "scsi: ufs: core: Probe for EXT_IID support"

From: Avri Altman
Date: Fri Jan 03 2025 - 02:45:43 EST


> Hi Avri,
>
> Although the patch itself looks fine to me, is the description accurate? "dead
> code" means code that is not executed. I think that the code removed by this
> patch gets executed?
Will fix.

>
> > diff --git a/include/ufs/ufshci.h b/include/ufs/ufshci.h index
> > 27364c4a6ef9..155f0801e907 100644
> > --- a/include/ufs/ufshci.h
> > +++ b/include/ufs/ufshci.h
> > @@ -23,7 +23,7 @@ enum {
> > /* UFSHCI Registers */
> > enum {
> > REG_CONTROLLER_CAPABILITIES = 0x00,
> > - REG_MCQCAP = 0x04,
> > + REG_MCQCAP = 0x04,
>
> Is this whitespace-only change really necessary?
I was using tab - will fix.

Thanks,
Avri

>
> Thanks,
>
> Bart.