RE: [PATCH] wifi: rtw88: 8703b: Fix RX/TX issues

From: Ping-Ke Shih
Date: Fri Jan 03 2025 - 04:13:38 EST


Vasily Khoruzhick <anarsoul@xxxxxxxxx> wrote:
> Fix 3 typos in 8703b driver. 2 typos in calibration routines are not
> fatal and do not seem to have any impact, just fix them to match vendor
> driver.

Just curious how you can find these typos?

>
> However the last one in rtw8703b_set_channel_bb() clears too many bits
> in REG_OFDM0_TX_PSD_NOISE, causing TX and RX issues (neither rate goes
> above MCS0-MCS1). Vendor driver clears only 2 most significant bits.
>
> With the last typo fixed, the driver is able to reach MCS7 on Pinebook
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 9bb762b3a957 ("wifi: rtw88: Add definitions for 8703b chip")
> Signed-off-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx>

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>

Is this urgent? If not, I will take this via rtw-next tree.