Re: [PATCH 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property

From: Peter Korsgaard
Date: Fri Jan 03 2025 - 04:17:04 EST


On 1/2/25 20:24, Rob Herring (Arm) wrote:

On Thu, 02 Jan 2025 18:50:40 +0100, Peter Korsgaard wrote:
The pwm-fan driver uses full PWM (255) duty cycle at startup, which may not
always be desirable because of noise or power consumption peaks, so add an
optional "default-pwm" property that can be used to specify a custom default
PWM duty cycle.

Signed-off-by: Peter Korsgaard <peter@xxxxxxxxxxxxx>
---
Documentation/devicetree/bindings/hwmon/pwm-fan.yaml | 7 +++++++
1 file changed, 7 insertions(+)


My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml: default-pwm: missing type definition
Error: Documentation/devicetree/bindings/hwmon/pwm-fan.example.dts:75.25-27 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/hwmon/pwm-fan.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2
make: *** [Makefile:251: __sub-make] Error 2

Ups, I added the entry to the example AFTER running make dt_binding_check and missed the <>, will fix.

--
Bye, Peter Korsgaard