Re: [PATCH] ps3disk: Do not use dev->bounce_size before it is set

[Geert Uytterhoeven]

Hi Christoph,

On Fri, Jan 3, 2025 at 9:56 AM Christoph Hellwig <hch@xxxxxx> wrote:
> On Fri, Jan 03, 2025 at 09:51:25AM +0100, Geert Uytterhoeven wrote:
> > dev->bounce_size is only initialized after it is used to set the queue
> > limits.  Fix this by using BOUNCE_SIZE instead.
> >
> > Fixes: a7f18b74dbe17162 ("ps3disk: pass queue_limits to blk_mq_alloc_disk")
> > Reported-by: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx>
> > Closes: https://lore.kernel.org/39256db9-3d73-4e86-a49b-300dfd670212@xxxxxxxxx
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Looks fine:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Thanks!

> But looking at the report it seems like no one cares about ps3 upstream,
> and in fact the only person caring at all rather rants on youtube than
> helping upstream, so maybe we should just remove the ps3 support entirely?

I am a bit surprised Geoff Levand didn't catch this in his regular testing...
Hmm, looks like his last Tested-by tag predates v6.9.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds