Re: [PATCH 0/3] module: Make .static_call_sites read-only after init

From: Christophe Leroy
Date: Fri Jan 03 2025 - 09:20:12 EST


Hi Petr,

Le 23/12/2024 à 10:37, Petr Pavlu a écrit :
Section .static_call_sites holds data structures that need to be sorted and
processed only at module load time. The section is never modified afterwards.
Make it therefore read-only after module initialization to avoid any
(non-)accidental modifications.

Petr Pavlu (3):
module: Constify parameters of module_enforce_rwx_sections()
module: Add a separate function to mark sections as read-only after
init
module: Make .static_call_sites read-only after init

kernel/module/internal.h | 7 ++++--
kernel/module/main.c | 18 +++------------
kernel/module/strict_rwx.c | 47 ++++++++++++++++++++++++++++++++++++--
3 files changed, 53 insertions(+), 19 deletions(-)



We have a problem at the moment with ro_after_init sections, isn't it better to fix it before adding new stuff to ro_after_init ?

This series conflicts with my series which aims at fixing up ro_after_init handling in modules, see https://patchwork.kernel.org/project/linux-modules/cover/cover.1733427536.git.christophe.leroy@xxxxxxxxxx/

I was expecting my series to land in modules-next, do you or Luis plan to take it anytime soon ?

Christophe