Re: [PATCH 1/6] jbd2: remove unused h_jdata flag of handle

[Jan Kara]

On Wed 25-12-24 04:27:02, Kemeng Shi wrote:
> Flag h_jdata is not used, just remove it.
> 
> Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza


> ---
>  include/linux/jbd2.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 50f7ea8714bf..c7fdb2b1b9a6 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -459,7 +459,6 @@ struct jbd2_revoke_table_s;
>   * @h_ref: Reference count on this handle.
>   * @h_err: Field for caller's use to track errors through large fs operations.
>   * @h_sync: Flag for sync-on-close.
> - * @h_jdata: Flag to force data journaling.
>   * @h_reserved: Flag for handle for reserved credits.
>   * @h_aborted: Flag indicating fatal error on handle.
>   * @h_type: For handle statistics.
> @@ -491,7 +490,6 @@ struct jbd2_journal_handle
>  
>  	/* Flags [no locking] */
>  	unsigned int	h_sync:		1;
> -	unsigned int	h_jdata:	1;
>  	unsigned int	h_reserved:	1;
>  	unsigned int	h_aborted:	1;
>  	unsigned int	h_type:		8;
> -- 
> 2.30.0
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR