Re: [PATCH 4/6] jbd2: remove stale comment of update_t_max_wait

From: Jan Kara
Date: Fri Jan 03 2025 - 09:39:52 EST


On Wed 25-12-24 04:27:05, Kemeng Shi wrote:
> Commit 2d44292058828 "jbd2: remove CONFIG_JBD2_DEBUG to update t_max_wait"
> removed jbd2_journal_enable_debug, just remove stale comment about
> jbd2_journal_enable_debug.
>
> Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx>

Sure. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

Honza

> ---
> fs/jbd2/transaction.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index 66513c18ca29..e00b87635512 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -119,7 +119,6 @@ static void jbd2_get_transaction(journal_t *journal,
> * t_max_wait is carefully updated here with use of atomic compare exchange.
> * Note that there could be multiplre threads trying to do this simultaneously
> * hence using cmpxchg to avoid any use of locks in this case.
> - * With this t_max_wait can be updated w/o enabling jbd2_journal_enable_debug.
> */
> static inline void update_t_max_wait(transaction_t *transaction,
> unsigned long ts)
> --
> 2.30.0
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR