Re: [PATCH v5 0/3] rust: kunit: Support KUnit tests with a user-space like syntax

[Miguel Ojeda]

On Fri, Dec 13, 2024 at 9:10 AM David Gow <davidgow@xxxxxxxxxx> wrote:
>
> v5 here is a small set of fixes and a rebase of the previous versions.
> If there are no major issues, I'd like to land this soon so it can be
> used and tested ready for 6.14.

Thanks as usual David for keeping this one alive over time.

I was thinking of applying this or giving you an Acked-by so that you
take it, but I ended up noticing a few things that I think need fixing
(the recommended mocking wouldn't work, warns/errors with 1.83,
duplicated/unused `static`s, intermediate mutable references being
created), so I sent a review. The good news is that we can simplify
the code (especially the generated one) while fixing those at the same
time. I hope the review helps.

I have put the review result here too (in a single commit, since I was
testing and didn't expect to fixup, sorry), in case it helps to see
the final result:

    https://github.com/ojeda/linux/commit/151681df53ac8ad52086f6758b51c6fb4414427b

If you agree with the changes (at least the big ones, i.e. that I
didn't miss something), then I think we can take it through KUnit or
Rust, though it may be a good idea to have the result in the list for
a few days (and/or put it early next cycle) given the magnitude of the
changes.

Finally, it is not a blocker for 6.14 or otherwise, but we should
eventually add/explain the new features in
`Documentation/rust/testing.rst`.

Thanks again!

Cheers,
Miguel