Re: [PATCH] cgroup/cpuset: fmeter_getrate() returns 0 when cpuset.memory_pressure disabled

[Michal Koutný]

On Thu, Dec 19, 2024 at 05:06:31PM +0800, Jin Guojie <guojie.jin@xxxxxxxxx> wrote:
> According to admin-guide/cgroup-v1/cpusets.rst,
> 
> "1.5 What is memory_pressure ?
>  ...
>   So only systems that enable this feature
>   (i.e. memory_pressure_enabled) will compute the metric."
> 
> To be consistent with the documentation, when memory_pressure_enabled is 0,
> cpuset.memory_pressure should always returns 0.

IMO a clearer fix would be to call fmeter_init() (again) when writing 1
to the memory_pressure_enabled.
At the same time, the docs interpretation is lose in what should be
shown (e.g. show last value, don't calculate updates), so it may need no
fix.

HTH,
Michal

Attachment: signature.asc
Description: PGP signature