Re: [PATCH 13/16] KVM: TDX: Add methods to ignore virtual apic related operation

[Vishal Annapurve]

On Sun, Dec 8, 2024 at 5:12 PM Binbin Wu <binbin.wu@xxxxxxxxxxxxxxx> wrote:
>
> From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx>
> ...
> +}
> +
>  static void vt_apicv_pre_state_restore(struct kvm_vcpu *vcpu)
>  {
>         struct pi_desc *pi = vcpu_to_pi_desc(vcpu);
> @@ -236,6 +245,22 @@ static void vt_apicv_pre_state_restore(struct kvm_vcpu *vcpu)
>         memset(pi->pir, 0, sizeof(pi->pir));

Should this be a nop for TDX VMs? pre_state_restore could cause
pending PIRs to get cleared as KVM doesn't have ability to sync them
to vIRR in absence of access to the VAPIC page.

>  }
>
> +static void vt_hwapic_irr_update(struct kvm_vcpu *vcpu, int max_irr)
> +{
> +       if (is_td_vcpu(vcpu))
> +               return;
> +
> +       return vmx_hwapic_irr_update(vcpu, max_irr);
> +}
> +