Re: [RFC PATCH v3 01/13] certs: Remove CONFIG_INTEGRITY_PLATFORM_KEYRING check
From: Eric Snowberg
Date: Fri Jan 03 2025 - 18:15:49 EST
> On Dec 23, 2024, at 6:21 AM, Mimi Zohar <zohar@xxxxxxxxxxxxx> wrote:
>
> Hi Eric,
>
> On Thu, 2024-10-17 at 09:55 -0600, Eric Snowberg wrote:
>> Remove the CONFIG_INTEGRITY_PLATFORM_KEYRING ifdef check so this
>> pattern does not need to be repeated with new code.
>>
>> Signed-off-by: Eric Snowberg <eric.snowberg@xxxxxxxxxx>
>
> Ok. The reason why testing the Kconfig is unnecessary should be included in the
> patch description. For example,
>
> Commit 219a3e8676f3 ("integrity, KEYS: add a reference to platform keyring")
> unnecessarily added the Kconfig test. As platform_trusted_keys is already
> initialized, simply use it.
Thanks, I'll add that in the next round.
> Reviewed-by: Mimi Zohar <zohar@xxxxxxxxxxxxx>