Re: [PATCH net-next v4 25/27] dt-bindings: net: pse-pd: microchip,pd692x0: Add manager regulator supply

[Krzysztof Kozlowski]

On Fri, Jan 03, 2025 at 10:13:14PM +0100, Kory Maincent wrote:
> From: Kory Maincent (Dent Project) <kory.maincent@xxxxxxxxxxx>
> 
> This patch adds the regulator supply parameter of the managers.

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> It updates also the example as the regulator supply of the PSE PIs
> should be the managers itself and not an external regulator.
> 
> Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> ---
> 
> Changes in v3:
> - New patch
> ---
>  .../devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml    | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml b/Documentation/devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml
> index fd4244fceced..0dc0da32576b 100644
> --- a/Documentation/devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml
> +++ b/Documentation/devicetree/bindings/net/pse-pd/microchip,pd692x0.yaml
> @@ -68,6 +68,9 @@ properties:
>            "#size-cells":
>              const: 0
>  
> +          vmain-supply:
> +            description: Regulator power supply for the PD69208X manager.

s/Regulator//
Keep it simple, no need to state obvious. What is not obvious here is
why there are no main device supplies (VDD, VDDA).

And what about VAUX5 and VAUX3P3? So basically the description is not
only redundant but actually incorrect because it suggests it is entire
supply, while there are others.

> +
>          patternProperties:
>            '^port@[0-7]$':
>              type: object
> @@ -106,10 +109,11 @@ examples:
>            #address-cells = <1>;
>            #size-cells = <0>;
>  
> -          manager@0 {
> +          manager0: manager@0 {
>              reg = <0>;
>              #address-cells = <1>;
>              #size-cells = <0>;
> +            vmain-supply = <&pse1_supply>;
>  
>              phys0: port@0 {
>                reg = <0>;
> @@ -128,7 +132,7 @@ examples:
>              };
>            };
>  
> -          manager@1 {
> +          manager1: manager@1 {

Not used.

Best regards,
Krzysztof