Re: [PATCH net-next v4 18/27] regulator: dt-bindings: Add regulator-power-budget property

[Kory Maincent]

On Sat, 4 Jan 2025 10:42:32 +0100
Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:

> On Fri, Jan 03, 2025 at 10:13:07PM +0100, Kory Maincent wrote:
> > From: Kory Maincent (Dent Project) <kory.maincent@xxxxxxxxxxx>
> > 
> > Introduce a new property to describe the power budget of the regulator.
> > This property will allow power management support for regulator consumers
> > like PSE controllers, enabling them to make decisions based on the
> > available power capacity.
> > 
> > Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> > ---
> > 
> > Changes in v3:
> > - Add type.
> > - Add unit in the name.
> > 
> > Changes in v2:
> > - new patch.
> > ---
> >  Documentation/devicetree/bindings/regulator/regulator.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/regulator/regulator.yaml
> > b/Documentation/devicetree/bindings/regulator/regulator.yaml index
> > 1ef380d1515e..c5a6b24ebe7b 100644 ---
> > a/Documentation/devicetree/bindings/regulator/regulator.yaml +++
> > b/Documentation/devicetree/bindings/regulator/regulator.yaml @@ -34,6
> > +34,11 @@ properties: regulator-input-current-limit-microamp:
> >      description: maximum input current regulator allows
> >  
> > +  regulator-power-budget-miniwatt:  
> 
> What sort of quantity prefix is a "mini"? How much is a mini?

Oops, that is a brain fart sorry for this. Of course it is milliwatt.

> 
> > +    description: power budget of the regulator
> > +    $ref: /schemas/types.yaml#/definitions/uint32  
> 
> This should not be needed. Use proper unit from dtschema.

Ok, I was mistaken. There are bindings with this ref in this file, so I thought
it was needed. I will remove it.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com