Re: [PATCH net v2] net: 802: LLC+SNAP OID:PID lookup on start of skb data

From: patchwork-bot+netdevbpf
Date: Sat Jan 04 2025 - 11:20:19 EST


Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@xxxxxxxxxx>:

On Thu, 2 Jan 2025 20:23:00 -0500 you wrote:
> 802.2+LLC+SNAP frames received by napi_complete_done() with GRO and DSA
> have skb->transport_header set two bytes short, or pointing 2 bytes
> before network_header & skb->data. This was an issue as snap_rcv()
> expected offset to point to SNAP header (OID:PID), causing packet to
> be dropped.
>
> A fix at llc_fixup_skb() (a024e377efed) resets transport_header for any
> LLC consumers that may care about it, and stops SNAP packets from being
> dropped, but doesn't fix the problem which is that LLC and SNAP should
> not use transport_header offset.
>
> [...]

Here is the summary with links:
- [net,v2] net: 802: LLC+SNAP OID:PID lookup on start of skb data
https://git.kernel.org/netdev/net/c/1e9b0e1c550c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html