Re: [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth

[Andreas Kemnade]

Hello Roger,

Am Sat, 4 Jan 2025 19:29:44 +0200
schrieb Roger Quadros <rogerq@xxxxxxxxxx>:

> Hello Andreas,
> 
> On 30/12/2024 01:01, Andreas Kemnade wrote:
> > Bluetooth is available on the other Panda board versions, too, so move
> > stuff to common and specify the needed clock properly.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> > ---
> >  .../boot/dts/ti/omap/omap4-panda-common.dtsi  | 30 +++++++++++++++--
> >  arch/arm/boot/dts/ti/omap/omap4-panda-es.dts  | 32 -------------------
> >  2 files changed, 28 insertions(+), 34 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
> > index c860b590142a..c048ab9af053 100644
> > --- a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
> > +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
> > @@ -368,9 +368,7 @@ OMAP4_IOPAD(0x130, PIN_INPUT_PULLUP | MUX_MODE0)	/* i2c4_sda */
> >  	wl12xx_gpio: wl12xx-gpio-pins {
> >  		pinctrl-single,pins = <
> >  			OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3)		/* gpmc_a19.gpio_43 */  
> 
> We could add function name in comment? e.g. /* gpmc_a19.gpio_43 - WLAN_EN */
> 
This is about existing code, there is still a lot of room to cleanup
other stuff. 

> > -			OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3)		/* gpmc_a22.gpio_46 */
> >  			OMAP4_IOPAD(0x070, PIN_OUTPUT_PULLUP | MUX_MODE3)	/* gpmc_a24.gpio_48 */  
> 
> This one is FM_EN and has nothing to do with WLAN.
> 
same here.
> > -			OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3)	/* gpmc_a25.gpio_49 */  
> >  		>;  
> >  	};
> >  
> > @@ -393,6 +391,22 @@ button_pins: button-pins {
> >  			OMAP4_IOPAD(0x114, PIN_INPUT_PULLUP | MUX_MODE3)	/* gpio_121 */  
> >  		>;  
> >  	};
> > +
> > +	bt_pins: bt-pins {
> > +		pinctrl-single,pins = <
> > +			OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3)	  /* BTEN */
> > +			OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* BTWAKEUP */  
> 
> Could we please use comment style <pin name>.<pinmux name> - Function
> 			OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3)		/* gpmc_a22.gpio_46 - BTEN */
> 			OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3)	/* gpmc_a25.gpio_49 - BTWAKEUP */
>
I was a bit lazy with checkpatch.pl. Your proposal generates a lot of
noise there, so I was too lazy to filter that noise, so I disabled that
noise. I had it first that way.

Regards,
Andreas