Re: [PATCH v3] lockdown: Initialize array before use

From: Tanya Agarwal
Date: Sun Jan 05 2025 - 12:52:40 EST


On Sun, Jan 5, 2025 at 11:18 PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
>
> On Jan 5, 2025 Tanya Agarwal <tanyaagarwal25699@xxxxxxxxx> wrote:
> >
> > The static code analysis tool "Coverity Scan" pointed the following
> > details out for further development considerations:
> > CID 1486102: Uninitialized scalar variable (UNINIT)
> > uninit_use_in_call: Using uninitialized value *temp when calling
> > strlen.
> >
> > Conclusion:
> > Initialize array before use in lockdown_read() to satisfy the static
> > analyzer.
> >
> > Fixes: 000d388ed3bb ("security: Add a static lockdown policy LSM")
> > Signed-off-by: Tanya Agarwal <tanyaagarwal25699@xxxxxxxxx>
>
> I removed the 'Fixes:' tag as the code isn't actually broken as we
> discussed in previous iterations of this patch. I also edited the
> subject line and commit description a bit, but otherwise this is
> fine. Merged into lsm/dev.
>
> --
> paul-moore.com


Thank you, Paul.

Regards,
Tanya