Re: [PATCH v15 01/13] x86/sev: Carve out and export SNP guest messaging init routines

[Nikunj A. Dadhania]

On 1/5/2025 12:36 AM, Francesco Lavra wrote:
> On 2024-12-03 at 9:00, Nikunj A Dadhania wrote:
> 
>> diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c
>> index c5b0148b8c0a..3cc741eefd06 100644
>> --- a/arch/x86/coco/sev/core.c
>> +++ b/arch/x86/coco/sev/core.c
> ...
>> +void snp_msg_free(struct snp_msg_desc *mdesc)
>> +{
>> +	if (!mdesc)
>> +		return;
>> +
>> +	mdesc->vmpck = NULL;
>> +	mdesc->os_area_msg_seqno = NULL;
>> +	kfree(mdesc->ctx);
>> +
>> +	free_shared_pages(mdesc->response, sizeof(struct
>> snp_guest_msg));
>> +	free_shared_pages(mdesc->request, sizeof(struct
>> snp_guest_msg));
>> +	iounmap((__force void __iomem *)mdesc->secrets);
>> +	kfree(mdesc);
> 
> This is leaking mdesc->certs_data.

Ack, will fix in the next version.

Regards
Nikunj