Re: [PATCH v2] wifi: wlcore: fix unbalanced pm_runtime calls

From: Nemanov, Michael
Date: Mon Jan 06 2025 - 01:23:12 EST


On 1/4/2025 9:55 PM, akemnade@xxxxxxxxxx wrote:
From: Andreas Kemnade <andreas@xxxxxxxxxxxx>

If firmware boot failes, runtime pm is put too often:
[12092.708099] wlcore: ERROR firmware boot failed despite 3 retries
[12092.708099] wl18xx_driver wl18xx.1.auto: Runtime PM usage count underflow!
Fix that by redirecting all error gotos before runtime_get so that runtime is
not put.

Fixes: c40aad28a3cf ("wlcore: Make sure firmware is initialized in wl1271_op_add_interface()")
Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>

Reviewed-by: Michael Nemanov <michael.nemanov@xxxxxx>

Best regards,
Michael.