Re: [PATCH v2 1/5] dt-bindings: platform: Add Huawei Matebook E Go EC

[Krzysztof Kozlowski]

On Mon, Jan 06, 2025 at 01:41:55AM +0800, Pengyu Luo wrote:
> +maintainers:
> +  - Pengyu Luo <mitltlatltl@xxxxxxxxx>
> +
> +description:
> +  Different from other Qualcomm Snapdragon sc8180x and sc8280xp-based
> +  machines, the Huawei Matebook E Go tablets use embedded controllers
> +  while others use a system called PMIC GLink which handles battery,
> +  UCSI, USB Type-C DP Alt Mode. In addition, Huawei's implementation
> +  also handles additional features, such as charging thresholds, FN
> +  lock, smart charging, tablet lid status, thermal sensors, and more.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - huawei,gaokun2
> +          - huawei,gaokun3

Missing "-ec", because gaokun2/3 is the name of the board, apparently. You cannot
duplicate compatibles with different meanings and if you tested this you
would see errors.

I think I might mislead you during last talk, where I questioned what is
"gen2" etc.

> +      - const: huawei,gaokun-ec

There is no support for gaokun2 here, so I assume you checked and you
know these are compatible. What's more, you claim there is a generic
piece of hardware called gaokun-ec and everything in this family will be
compatible with it. Well, that's my standard disclaimer and disapproval
of using generic compatibles.

So in general what you want here is *only one* compatible called
huawei,gaokun3-ec

> +
> +  reg:
> +    const: 0x38
> +
> +  '#address-cells':
> +    const: 1
> +
> +  '#size-cells':
> +    const: 0
> +
> +  interrupts:
> +    maxItems: 1
> +
> +patternProperties:
> +  '^connector@[01]$':
> +    $ref: /schemas/connector/usb-connector.yaml#
> +
> +    properties:
> +      reg:
> +        maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |+

Drop +

Best regards,
Krzysztof