Re: [PATCH v2 1/5] dt-bindings: platform: Add Huawei Matebook E Go EC
From: Krzysztof Kozlowski
Date: Mon Jan 06 2025 - 07:31:24 EST
On 06/01/2025 09:06, Pengyu Luo wrote:
>>> + - const: huawei,gaokun-ec
>>
>> There is no support for gaokun2 here, so I assume you checked and you
>> know these are compatible. What's more, you claim there is a generic
>> piece of hardware called gaokun-ec and everything in this family will be
>> compatible with it. Well, that's my standard disclaimer and disapproval
>> of using generic compatibles.
>>
>> So in general what you want here is *only one* compatible called
>> huawei,gaokun3-ec
>>
>
> I agree with you. If there is a generic rule to follow, I am not familiar
> with this. I have seen some bindings, using like this, so I followed it
> recently.
Generic rule is: wildcards and family names are not allowed. Now what
"generic" means, is different for different devices. If unsure, always
use only device-specific compatibles.
Best regards,
Krzysztof