Re: [PATCH v2] PCI: rcar-ep: Fix the issue of the name parameter when calling devm_request_mem_region

[Lad, Prabhakar]

On Sun, Jan 5, 2025 at 6:03 AM <kingdix10@xxxxxx> wrote:
>
> From: King Dix <kingdix10@xxxxxx>
>
> When using devm_request_mem_region to request a resource, if the passed
> variable is a stack string variable, it will lead to an oops issue when
> eecuting the command cat /proc/iomem.
>
s/eecuting/executing

> Fix this by replacing outbound_name with the name of the previously
> requested resource.
>
Fixes: 2a6d0d63d999 ("PCI: rcar: Add endpoint mode support")
> Signed-off-by: King Dix <kingdix10@xxxxxx>
> ---
> Changes in v2:
>   - Fix the code indentation issue.
> ---
>  drivers/pci/controller/pcie-rcar-ep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
With the above fixed,

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Cheers,
Prabhakar

> diff --git a/drivers/pci/controller/pcie-rcar-ep.c b/drivers/pci/controller/pcie-rcar-ep.c
> index 047e2cef5afc..c5e0d025bc43 100644
> --- a/drivers/pci/controller/pcie-rcar-ep.c
> +++ b/drivers/pci/controller/pcie-rcar-ep.c
> @@ -107,7 +107,7 @@ static int rcar_pcie_parse_outbound_ranges(struct rcar_pcie_endpoint *ep,
>                 }
>                 if (!devm_request_mem_region(&pdev->dev, res->start,
>                                              resource_size(res),
> -                                            outbound_name)) {
> +                                            res->name)) {
>                         dev_err(pcie->dev, "Cannot request memory region %s.\n",
>                                 outbound_name);
>                         return -EIO;
> --
> 2.43.0
>
>