Re: [PATCH 2/7] ext4: Remove a redundant return statement

From: Jan Kara
Date: Mon Jan 06 2025 - 10:23:16 EST


On Fri 20-12-24 23:16:20, Julian Sun wrote:
> Remove a redundant return statements in the
> ext4_es_remove_extent() function.
>
> Signed-off-by: Julian Sun <sunjunchao2870@xxxxxxxxx>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

Honza

> ---
> fs/ext4/extents_status.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
> index c786691dabd3..c56fb682a27e 100644
> --- a/fs/ext4/extents_status.c
> +++ b/fs/ext4/extents_status.c
> @@ -1551,7 +1551,6 @@ void ext4_es_remove_extent(struct inode *inode, ext4_lblk_t lblk,
>
> ext4_es_print_tree(inode);
> ext4_da_release_space(inode, reserved);
> - return;
> }
>
> static int __es_shrink(struct ext4_sb_info *sbi, int nr_to_scan,
> --
> 2.39.5
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR