Re: [PATCH v7 2/3] netfilter: x_tables: Merge xt_*.c files which has same name.

[Jan Engelhardt]

On Monday 2025-01-06 15:22, Andrew Lunn wrote:
>> x86_64-before:
>> text    data     bss     dec     hex filename
>>  716     432       0    1148     47c xt_dscp.o
>> 1142     432       0    1574     626 xt_DSCP.o
>>  593     224       0     817     331 xt_hl.o
>>  934     224       0    1158     486 xt_HL.o
>> 1099     120       0    1219     4c3 xt_rateest.o
>> 2126     365       4    2495     9bf xt_RATEEST.o
>>  747     224       0     971     3cb xt_tcpmss.o
>> 2824     352       0    3176     c68 xt_TCPMSS.o
>> total data: 2373
>> 
>> x86_64-after:
>> text    data     bss     dec     hex filename
>> 1709     848       0    2557     9fd xt_dscp.o
>> 1352     448       0    1800     708 xt_hl.o
>> 3075     481       4    3560     de8 xt_rateest.o
>> 3423     576       0    3999     f9f xt_tcpmss.o
>> total data: 2353
>
>So you have saved 20 bytes in the data segment. A 0.8% reduction. If i
>was developing this patchset, when i see this number, i would
>immediately think, why am i bothering?

Before:
$ lsmod
xt_TCPMSS              12288  0
xt_tcpmss              12288  0

After:
$ lsmod
xt_tcpmss              12288  0

which is a 50% reduction in run-time memory use.