Re: [PATCH v3] eth: fbnic: Revert "eth: fbnic: Add hardware monitoring support via HWMON interface"

[Jakub Kicinski]

On Mon,  6 Jan 2025 10:36:48 +0800 Su Hui wrote:
> There is a garbage value problem in fbnic_mac_get_sensor_asic(). 'fw_cmpl'
> is uninitialized which makes 'sensor' and '*val' to be stored garbage
> value. Revert commit d85ebade02e8 ("eth: fbnic: Add hardware monitoring
> support via HWMON interface") to avoid this problem.
> 
> Fixes: d85ebade02e8 ("eth: fbnic: Add hardware monitoring support via HWMON interface")
> Signed-off-by: Su Hui <suhui@xxxxxxxxxxxx>
> Suggested-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Suggested-by: Michal Swiatkowski <michal.swiatkowski@xxxxxxxxxxxxxxx>

Reviewed-by: Jakub Kicinski <kuba@xxxxxxxxxx>

Thanks!