Re: [PATCH] x86/sev: Don't hang but terminate on failure to remap SVSM CA
From: Ard Biesheuvel
Date: Mon Jan 06 2025 - 11:28:48 EST
On Mon, 6 Jan 2025 at 17:10, Tom Lendacky <thomas.lendacky@xxxxxxx> wrote:
>
> On 1/6/25 09:57, Ard Biesheuvel wrote:
> > From: Ard Biesheuvel <ardb@xxxxxxxxxx>
> >
> > Commit
> >
> > 09d35045cd0f ("x86/sev: Avoid WARN()s and panic()s in early boot code")
> >
> > replaced a panic() that could potentially hit before the kernel is even
> > mapped with a deadloop, to ensure that execution does not proceed when
> > the condition in question hits.
> >
> > As Tom suggests, it is better to terminate and return to the hypervisor
> > in this case, using a newly invented failure code to describe the
> > failure condition.
> >
> > Suggested-by: Tom Lendacky <thomas.lendacky@xxxxxxx>
> > Link: https://lore.kernel.org/all/9ce88603-20ca-e644-2d8a-aeeaf79cde69@xxxxxxx
> > Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
>
> Sorry Ard, I hadn't realized that the series was already merged or I
> would have submitted the patch myself. Thanks for doing this!
>
No worries
> Reviewed-by: Tom Lendacky <thomas.lendacky@xxxxxxx>
>
Thanks