Re: [PATCH v2] hwmon: pmbus: dps920ab: Add ability to instantiate through i2c

[Guenter Roeck]

On Fri, Dec 27, 2024 at 01:59:55PM +0300, Denis Kirjanov wrote:
> Currently I have an x86-based system with a Delta PSU
> attched to it thought the i2c bus and OF is disabled.
> That means that in the configuration above I can't instantiate
> an i2c driver since the driver doesn't have the i2c match table.
> 
> Let's add the ability to match the driver with i2c like the
> following command:
> 
> echo "dps920ab" 0x58 > /sys/bus/i2c/devices/i2c-0/new_device
> ...
> [616189.076211] i2c i2c-0: new_device: Instantiated device dps920ab at 0x58
> 
> v2: add more verbose changelog
> 
> Signed-off-by: Denis Kirjanov <kirjanov@xxxxxxxxx>

Documentation/process/submitting-patches.rst,
"The canonical patch format", describes in detail how a patch
description should look like. Anything from "The explanation body"
onwards is relevant here.

A useful patch description would be a simple "Add support for
instantiating the Delta DPS920AB PSU through I2C on systems without
devicetree support". Everything else is irrelevant for the patch
description and, if desired, should be after "---".

Thanks,
Guenter