Re: wakeup_pipe_readers/writers() && pipe_poll()

From: Oleg Nesterov
Date: Mon Jan 06 2025 - 13:37:40 EST


On 01/06, Linus Torvalds wrote:
>
> On Mon, 6 Jan 2025 at 08:31, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> >
> > To be honest, I don't understand the wait_address check in poll_wait(),
> > it seems that wait_address is never NULL.
>
> Oh, it seems to be historical.

Yeah, please see my previous email.

I think it must die, but needs another one-liner.

> > That is what I tried to propose. Will you agree with this change?
> > We can even use smp_store_mb(), say
>
> I think it's clearer to just use smp_mb().

OK, agreed, I'll send the trivial patch once I write the changelog.

Oleg.