Re: [PATCH v2 11/25] KVM: TDX: Add placeholders for TDX VM/vCPU structures

From: Edgecombe, Rick P
Date: Mon Jan 06 2025 - 14:00:51 EST


On Sun, 2025-01-05 at 11:58 +0100, Francesco Lavra wrote:
> > +static inline struct kvm_tdx *to_kvm_tdx(struct kvm *kvm) { return
> > NULL; }
> > +static inline struct vcpu_tdx *to_tdx(struct kvm_vcpu *vcpu) {
> > return NULL; }
>
> IMO the definitions of to_kvm_tdx() and to_tdx() shouldn't be there
> when CONFIG_INTEL_TDX_HOST is not defined: they are (and should be)
> only used in CONFIG_INTEL_TDX_HOST code.

Seems reasonable. Thanks.