Re: [PATCH 3/3] hwmon/adt7470: create 'temp_fan_norm_alarm' attribute for 'NORM' alarm
From: Guenter Roeck
Date: Mon Jan 06 2025 - 14:10:27 EST
On 1/5/25 11:55, Adrian DC wrote:
Default: 0 in all normal use cases
Test: Raises to 1 if all FANs are in automatic mode and below threshold
As with the other patches, this is not an acceptable patch description.
On top of that, it introduces a non-standard attribute without documenting
it nor providing a rationale explaining the need for it. Also, this is not
an alarm. The bit says "everything is normal". I fail to see the value of
such an attribute, much less as an "alarm" attribute.
Guenter