Re: [PATCH net-next v1] net: stmmac: Unexport stmmac_rx_offset() from stmmac.h
From: Andrew Lunn
Date: Mon Jan 06 2025 - 16:06:09 EST
> +static inline unsigned int stmmac_rx_offset(struct stmmac_priv *priv)
> +{
> + if (stmmac_xdp_is_enabled(priv))
> + return XDP_PACKET_HEADROOM;
> +
> + return 0;
> +}
Please drop the inline keyword. You don't need it in a .c file, it is
better to let the compiler to decide.
Andrew
---
pw-bot: cr