Re: [PATCH] perf test trace_btf_general: Fix shellcheck warning

[Namhyung Kim]

On Mon, Jan 06, 2025 at 04:42:58PM +0000, James Clark wrote:
> Shellcheck versions < v0.7.2 can't follow this path so add the helper to
> fix the following warning:
> 
>   tests/shell/trace_btf_general.sh line 8:
>   . "$(dirname $0)"/lib/probe.sh
>   ^--------------------------^ SC1090: Can't follow non-constant source.
>   Use a directive to specify location.
> 
> Fixes: 0255338d6975 ("perf trace: Add tests for BTF general augmentation")
> Signed-off-by: James Clark <james.clark@xxxxxxxxxx>
> ---

Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks,
Namhyung

>  tools/perf/tests/shell/trace_btf_general.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/tests/shell/trace_btf_general.sh b/tools/perf/tests/shell/trace_btf_general.sh
> index 005c93e6c770..e9ee727f3433 100755
> --- a/tools/perf/tests/shell/trace_btf_general.sh
> +++ b/tools/perf/tests/shell/trace_btf_general.sh
> @@ -5,6 +5,7 @@
>  err=0
>  set -e
>  
> +# shellcheck source=lib/probe.sh
>  . "$(dirname $0)"/lib/probe.sh
>  
>  file1=$(mktemp /tmp/file1_XXXX)
> -- 
> 2.34.1
>