Re: [PATCH v5 02/12] crypto: acomp - Define new interfaces for compress/decompress batching.

From: Herbert Xu
Date: Mon Jan 06 2025 - 21:07:09 EST


On Mon, Jan 06, 2025 at 05:46:01PM -0800, Yosry Ahmed wrote:
>
> For software compressors, the batch size should be 1. In that
> scenario, from a zswap perspective (without going into the acomp
> implementation details please), is there a functional difference? If
> not, we can just use the request chaining API regardless of batching
> if that is what Herbert means.

If you can supply a batch size of 8 for iaa, there is no reason
why you can't do it for software algorithms. It's the same
reason that we have GSO in the TCP stack, regardless of whether
the hardware can handle TSO.

The amortisation of the segmentation cost means that it will be
a win over-all.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt