Re: [PATCH 1/4] drm/msm/dsi: Drop redundant NULL-ifying of clocks on error paths

[Abhinav Kumar]

On 1/6/2025 12:49 AM, Krzysztof Kozlowski wrote:
> dsi_clk_init(), which gets the clocks, is called only through platform
> driver probe and its failure is a failure of the probe.  Therefore
> NULL-ifying specific clocks is pointless and redundant - the PTR_ERR
> value stored there won't be used/dereferenced afterwards.  What's more,
> variant-specific clock init calls like dsi_clk_init_6g_v2() are not
> doing this cleanup.  Dropping redundant code allows later to make this a
> bit simpler.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
>   drivers/gpu/drm/msm/dsi/dsi_host.c | 3 ---
>   1 file changed, 3 deletions(-)

Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>