Re: [PATCH v3] arm64: dts: qcom: Add coresight node for SM8650

From: Yuanfang Zhang
Date: Tue Jan 07 2025 - 03:52:44 EST




On 1/3/2025 8:44 PM, Konrad Dybcio wrote:
> On 3.01.2025 12:27 PM, Yuanfang Zhang wrote:
>> Add coresight components: Funnel, ETE and ETF for SM8650.
>>
>> Signed-off-by: Yuanfang Zhang <quic_yuanfang@xxxxxxxxxxx>
>> ---
>
> [...]
>
>> +
>> + funnel@13810000 {
>> + compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
>> +
>> + reg = <0x0 0x13810000 0x0 0x1000>;
>
> This now looks good, please just re-sort these nodes (by address instead
> of adding them at the end).
updated in patch V4.
>
> Also, did you give this patch a try on a production-fused device?
>
Yes, it was verified on Snapdragon 8Gen3 platform device.
> Konrad