Re: [PATCH v13 04/10] dt-bindings: mfd: add maxim,max77705

[Dzmitry Sankouski]

пн, 23 дек. 2024 г. в 18:52, Krzysztof Kozlowski <krzk@xxxxxxxxxx>:
(...)
> > +
> > +  leds:
> > +    type: object
> > +    additionalProperties: false
> > +    description:
> > +      Up to 4 LED channels supported.
> > +
> > +    patternProperties:
> > +      "^led@[0-3]$":
>
> 0-2? 1-3? Preferred is the first, because we index unit addresses from
> 0.

max77705 supports 4 led channels, i.e. rgbw, hence 0-3.

>
> Please move "patternProperties" after the "properties:" block.
> Compatible should be the first thing visible to the reader.
>

ok

(...)
> > +
> > +        patternProperties:
> > +          "^led@[0-3]$":
>
> Same - 0-2
>

max77705 supports 4 led channels, i.e. rgbw, hence 0-3.

-- 
Best regards and thanks for review,
Dzmitry