Re: [PATCH 1/2] rt2x00: Remove unusued value

[Stanislaw Gruszka]

Hi Ariel,

On Mon, Jan 06, 2025 at 08:23:34AM +0100, Ariel Otilibili-Anieli wrote:
> Hi Daniel, hi Shiji, hi Stanislaw,
> 
> On Sunday, January 05, 2025 22:21 CET, Daniel Golle <daniel@xxxxxxxxxxxxxx> wrote:
> 
> > H again,
> > 
> > 
> > On Sat, Jan 04, 2025 at 01:51:25PM +0100, Ariel Otilibili-Anieli wrote:
> > > Great, then; thanks for having acked the patch as such.
> > 
> > I just noticed that Shiji Yang had posted a series of patches for
> > OpenWrt which also addresses the same issue, however, instead of
> > removing the augmented assignment, it fixes it to the supposedly
> > originally intended way.
> > 
> > See
> > https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=package/kernel/mac80211/patches/rt2x00/621-04-rt2x00-fix-register-operation-on-RXIQ-calibration.patch;h=aa6f9c437c6447831490588b2cead6919accda58;hb=5d583901657bdfbbf9fad77d9247872427aa5c99
> > 
> > I suppose this was tested together with the other changes of the same
> > series, so we may want to pick that instead.
> 
> Thanks for having put some time into the research, Daniel; I looked into the openwrt archives for 2024, none of Shiji’s messages mentions that patch.
> 
> Though, if you three agree, I will push a new series, modelled on that patch, and you as Suggested-by.

Please post that change. But to not mix it with
patches against other drivers in the same series.
(multiple rt2x00 patches in one patchset are ok).

And please use "wifi: rt2x00:" as subject prefix.

Thanks
Stanislaw