RE: [PATCH v3 4/6] clk: renesas: rzv2h: Switch MSTOP configuration to per-bit basis

[Biju Das]

Hi Prabhakar,

Thanks for the patch.

> -----Original Message-----
> From: Prabhakar <prabhakar.csengg@xxxxxxxxx>
> Sent: 02 January 2025 18:19
> Subject: [PATCH v3 4/6] clk: renesas: rzv2h: Switch MSTOP configuration to per-bit basis
> 
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> 
> Switch MSTOP handling from group-based to per-bit configuration to address issues with shared
> dependencies between module clocks. In the current group-based configuration, multiple module clocks
> may rely on a single MSTOP bit. When both clocks are turned ON and one is subsequently turned OFF, the
> shared MSTOP bit will still be set, which is incorrect since the other dependent module clock remains
> ON. 

I guess this statement is incorrect. Still in group-based, mstop bit is controlled by usage count(ref_cnt).
The real advantage with per-bit configuration is, we can drop index manipulation.

Cheers,
Biju