Re: [PATCH V6 14/15] cpufreq: Add Rust based cpufreq-dt driver

[Greg KH]

On Tue, Jan 07, 2025 at 04:51:47PM +0530, Viresh Kumar wrote:
> +impl platform::Driver for CPUFreqDTDriver {
> +    type IdInfo = ();
> +    const OF_ID_TABLE: Option<of::IdTable<Self::IdInfo>> = Some(&OF_TABLE);
> +
> +    fn probe(pdev: &mut platform::Device, _id_info: Option<&Self::IdInfo>) -> Result<Pin<KBox<Self>>> {
> +        cpufreq::Registration::<CPUFreqDTDriver>::new_foreign_owned(
> +            pdev.as_ref(),
> +            c_str!("cpufreq-dt"),
> +            (),
> +            cpufreq::flags::NEED_INITIAL_FREQ_CHECK | cpufreq::flags::IS_COOLING_DEV,
> +            true,
> +        )?;
> +
> +        pr_info!("CPUFreq DT driver registered\n");

When drivers work properly, they are quiet.  Please don't make us have
to go and remove lines like this from new drivers being added to the
tree like we did for older drivers in the past :(

thanks,

greg k-h