Re: [PATCH V6 03/15] cpufreq: Rust implementation doesn't parse BIT() macro

From: Daniel Almeida
Date: Tue Jan 07 2025 - 08:30:48 EST


Hi,

> On 7 Jan 2025, at 09:00, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, Jan 07, 2025 at 04:51:36PM +0530, Viresh Kumar wrote:
>> Rust isn't able to parse the macro for now, avoid using it.
>
> No, please fix it. You don't want to have to fend off the checkpatch.pl
> cleanups that this would cause of people putting the BIT() macro back.
>
> Make BIT() work properly for Rust code as well, it has to be done
> eventually, right?
>
> thanks,
>
> greg k-h
>


Viresh, FYI, there’s already a patch for this floating around [0].

I can send a new version today. From Alice’s last comments, it only
needs a minor fix anyways.

— Daniel

[0] https://lore.kernel.org/rust-for-linux/20241024-topic-panthor-rs-genmask-v2-1-85237c1f0cea@xxxxxxxxxxxxx/