Re: [PATCH] KVM: x86/mmu: Only zap valid non-mirror roots in kvm_zap_gfn_range()

[Paolo Bonzini]

On Tue, Jan 7, 2025 at 12:49 AM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
> On Mon, Dec 23, 2024, Yan Zhao wrote:
> > On Sun, Dec 22, 2024 at 08:28:56PM +0100, Paolo Bonzini wrote:
> > > I think we should treat honoring of guest PAT like zap-memslot-only,
> > > and make it a quirk that TDX disables.  Making it a quirk adds a bit of
> > > complexity, but it documents why the code exists and it makes it easy for
> > > TDX to disable it.
>
> Belated +1.  Adding a quirk for honoring guest PAT was on my todo list.  A quirk
> also allows setups that don't provide a Bochs device to honor guest PAT, which
> IIRC is needed for virtio-gpu with a non-snooping graphics device.
>
> > Thanks! Will do in this way after the new year.
>
> Nice!  One oddity to keep in mind when documenting the quirk is that KVM always
> honors guest PAT when running on AMD.  :-/

And also when implementing it - the quirk should be absent on AMD.

Paolo