Re: [PATCH] arm64: dts: qcom: x1e78100-t14s: Enable fingerprint reader

From: Abel Vesa
Date: Tue Jan 07 2025 - 09:38:42 EST


On 25-01-07 15:35:07, Abel Vesa wrote:
> On Lenovo ThinkPad T14s, the fingerprint reader placed in the power
> button is connected via the usb_2 controller. The controller has only
> a USB 2.0 PHY which is then connected via a NXP PTN3222 eUSB2 repeater,
> which in turn is connected to the Goodix fingerprint reader.
>
> So enable all the usb_2 controller and PHY nodes, set dual-role mode to
> host and describe the eUSB2 repeater in order to get the fingerprint
> reader discovered.
>
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>

Turns out that on resume a couple of things are broken w.r.t. to the usb_2 controller:

[ 41.104913] arm-smmu 15000000.iommu: Unhandled context fault: fsr=0x402, iova=0xe2010600, fsynr=0x110001, cbfrsynra=0x14e0, cb
[ 41.104936] arm-smmu 15000000.iommu: FSR = 00000402 [Format=2 TF], SID=0x14e0
[ 41.104950] arm-smmu 15000000.iommu: FSYNR0 = 00110001 [S1CBNDX=17 PLVL=1]
[ 51.420689] xhci-hcd xhci-hcd.6.auto: xHCI host not responding to stop endpoint command
[ 51.420702] xhci-hcd xhci-hcd.6.auto: xHCI host controller not responding, assume dead
[ 51.420720] xhci-hcd xhci-hcd.6.auto: HC died; cleaning up
[ 51.420836] usb 5-1: PM: dpm_run_callback(): usb_dev_resume returns -22
[ 51.420864] usb 5-1: PM: failed to resume async: error -22

So do not apply this yet.

Sorry for not testing this properly before sending.