Re: [PATCH] soc: qcom: socinfo: Avoid out of bounds read of serial number

[Bjorn Andersson]

On Mon, 30 Dec 2024 20:59:35 +0100, Stephan Gerhold wrote:
> On MSM8916 devices, the serial number exposed in sysfs is constant and does
> not change across individual devices. It's always:
> 
>   db410c:/sys/devices/soc0$ cat serial_number
>   2644893864
> 
> The firmware used on MSM8916 exposes SOCINFO_VERSION(0, 8), which does not
> have support for the serial_num field in the socinfo struct. There is an
> existing check to avoid exposing the serial number in that case, but it's
> not correct: When checking the item_size returned by SMEM, we need to make
> sure the *end* of the serial_num is within bounds, instead of comparing
> with the *start* offset. The serial_number currently exposed on MSM8916
> devices is just an out of bounds read of whatever comes after the socinfo
> struct in SMEM.
> 
> [...]

Applied, thanks!

[1/1] soc: qcom: socinfo: Avoid out of bounds read of serial number
      commit: 22cf4fae6660b6e1a583a41cbf84e3046ca9ccd0

Best regards,
-- 
Bjorn Andersson <andersson@xxxxxxxxxx>