Re: [PATCH 1/4] hwmon: (oxp-sensors) Separate logic from device-specific data
From: Guenter Roeck
Date: Tue Jan 07 2025 - 12:34:21 EST
On Fri, Dec 27, 2024 at 12:05:27AM +0100, Tobias Jakobi wrote:
> On 12/26/24 22:04, Guenter Roeck wrote:
>
...
>
> > If such checks happen in the current code, that should be fixed
> > in the is_visible functions. Any existing runtime feature checks
> > should be removed.
> OK, so to reiterate: We don't want any feature checks during runtime. Only
> during probe time. And during probe we just create the attributes that make
> sense for the device. What we can't decide on the level of attributes, we do
> in the is_visible functions. Is this correct?
>
Correct.
Thanks,
Guenter