Re: [PATCH v2 5/6] ASoC: rt722-sdca: Add some missing readable registers
From: Pierre-Louis Bossart
Date: Tue Jan 07 2025 - 15:13:12 EST
> + case SDW_SDCA_CTL(FUNC_NUM_JACK_CODEC, RT722_SDCA_ENT_USER_FU05,
> + RT722_SDCA_CTL_FU_MUTE, CH_L) ...
> + SDW_SDCA_CTL(FUNC_NUM_JACK_CODEC, RT722_SDCA_ENT_USER_FU05,
> + RT722_SDCA_CTL_FU_MUTE, CH_R):
> + case SDW_SDCA_CTL(FUNC_NUM_JACK_CODEC, RT722_SDCA_ENT_XU0D,
> + RT722_SDCA_CTL_SELECTED_MODE, 0):
nit-pick: maybe we should have a shorter macro when the Channel Number is not used? Using zero here means there is no channel-specific control, not an explicit intent to program ch0 and ignore chN with N>0.