Re: [PATCH 6/6] jbd2: Correct stale comment of release_buffer_page

From: Zhang Yi
Date: Tue Jan 07 2025 - 22:28:13 EST


On 2024/12/25 4:27, Kemeng Shi wrote:
> Update stale lock info in comment of release_buffer_page.
>
> Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx>

Looks good to me.

Reviewed-by: Zhang Yi <yi.zhang@xxxxxxxxxx>

> ---
> fs/jbd2/commit.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c
> index 9153ff3a08e7..d812d15f295e 100644
> --- a/fs/jbd2/commit.c
> +++ b/fs/jbd2/commit.c
> @@ -57,8 +57,8 @@ static void journal_end_buffer_io_sync(struct buffer_head *bh, int uptodate)
> * So here, we have a buffer which has just come off the forget list. Look to
> * see if we can strip all buffers from the backing page.
> *
> - * Called under lock_journal(), and possibly under journal_datalist_lock. The
> - * caller provided us with a ref against the buffer, and we drop that here.
> + * Called under j_list_lock. The caller provided us with a ref against the
> + * buffer, and we drop that here.
> */
> static void release_buffer_page(struct buffer_head *bh)
> {