Re: [PATCH v6 3/5] dt-bindings: PCI: qcom: Document the IPQ5332 PCIe controller

From: Krzysztof Kozlowski
Date: Wed Jan 08 2025 - 02:22:02 EST


On 08/01/2025 06:58, Varadarajan Narayanan wrote:
> Document the PCIe controller on IPQ5332 platform. IPQ5332 will
> use IPQ9574 as the fall back compatible.
>
> All DT entries except "reg" is similar between ipq5332 and
> ipq9574. ipq9574 has 5 registers while ipq5332 has 6. MHI is the
> additional (i.e. sixth entry). Since this matches with the
> sdx55's "reg" definition which allows for 5 or 6 registers,
> combine ipq9574 and ipq5332 with sdx55. Without this
> dt_binding_check fails.
>
> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> ---
> v6: Commit message update only. Add info regarding the moving of
> ipq9574 from 5 "reg" definition to 5 or 6 reg definition.
>
You gave yourself 4 days to respond to my comment.

To me, you gave around 18h, through most of the time I was offline or
sleeping, and then sent new version.

NAK, implement the feedback and keep discussing in the previous version.

Best regards,
Krzysztof