Re: [PATCH] m68k/atari: Use str_on_off() helper in atari_nvram_proc_read()

[Geert Uytterhoeven]

On Fri, Dec 6, 2024 at 12:57 PM Thorsten Blum <thorsten.blum@xxxxxxxxx> wrote:
> Remove hard-coded strings by using the str_on_off() helper function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
i.e. will queue in the m68k tree for v6.14.

I am adding

    #include <linux/string_choices.h>

while applying, as currently this relies on lots of implicit includes:

    arch/m68k/atari/nvram.c:#include <linux/seq_file.h>
    include/linux/seq_file.h:#include <linux/string_helpers.h>
    include/linux/string_helpers.h:#include <linux/string_choices.h>
    include/linux/string_choices.h:static inline const char *str_on_off(bool v)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds